Conversation
tlroy
added
ready for review
tupek2
reviewed
Mar 11, 2026
Collaborator
tupek2
left a comment
tupek2
left a comment
There was a problem hiding this comment.
Do the new preconditioners need to set height/width in their SetOperator implementations?
lihanyu97
reviewed
Mar 11, 2026
lihanyu97
reviewed
Mar 11, 2026
lihanyu97
reviewed
Mar 11, 2026
lihanyu97
reviewed
Mar 11, 2026
lihanyu97
reviewed
Mar 11, 2026
lihanyu97
reviewed
Mar 11, 2026
lihanyu97
reviewed
Mar 11, 2026
lihanyu97
reviewed
Mar 11, 2026
lihanyu97
reviewed
Mar 11, 2026
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
Co-authored-by: Hanyu Li <125513291+lihanyu97@users.noreply.github.com>
… roy/block_preconditioner
tupek2
approved these changes
Mar 13, 2026
Collaborator
tupek2
left a comment
tupek2
left a comment
There was a problem hiding this comment.
I ran this with asan and didnt see any memory issues. Doesn't mean they aren't there, but gives me more confidence. Have to be careful with mfem, as they sometimes take over the memory, sometimes not. Thanks for taking another careful sweep through.
lihanyu97
approved these changes
Mar 13, 2026
Contributor
lihanyu97
left a comment
lihanyu97
left a comment
There was a problem hiding this comment.
Things look good and clean. Thanks for making an effort to develop this capability!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add block preconditioners to be used in
LinearDifferentiableBlockSolver. This includes block diagonal (additive fieldsplit), block triangular (multiplicative fieldsplit) for arbitrary N x N block systems, as well as Schur complement factorizations for 2x2 systems, with a standard Schur complement approximation (selfp).